[KGP] Default classpath metadata to the common sources IC property - #7638
Open
Iveta Kovalenko (ywett02) wants to merge 1 commit into
Open
[KGP] Default classpath metadata to the common sources IC property#7638Iveta Kovalenko (ywett02) wants to merge 1 commit into
Iveta Kovalenko (ywett02) wants to merge 1 commit into
Conversation
`enableJvmClasspathMetadata` defaulted to `false`, so opting into `kotlin.jvm.enableIncrementalCompilationOfCommonSources` alone left common sources compiled incrementally without the isolated fragment dependency view that keeps them from resolving against platform declarations - the KT-62686 problem the classpath metadata exists to prevent. Default it to the value of the common sources IC property instead, so that enabling common sources IC also enables the mechanism that makes it correct. The internal property still wins when set explicitly, so it remains a kill switch for turning the metadata off on its own. ^KT-88763 Fixed
Code Owners
PR commands for maintainers
|
Iveta Kovalenko (ywett02)
requested review from
a team,
Egor Andreevich (Egorand),
Yahor Berdnikau (Tapchicoma) and
Timofey Solonin (timofeys1)
and removed request for
a team,
Yahor Berdnikau (Tapchicoma) and
Timofey Solonin (timofeys1)
August 21, 2026 14:07
Egor Andreevich (Egorand)
approved these changes
Aug 21, 2026
Egor Andreevich (Egorand)
left a comment
Egor Andreevich (Egorand)
left a comment
Contributor
There was a problem hiding this comment.
/final
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enableJvmClasspathMetadatadefaulted tofalse, so opting intokotlin.jvm.enableIncrementalCompilationOfCommonSourcesalone left common sources compiled incrementally without the isolated fragment dependency view that keeps them from resolving against platform declarations - the KT-62686 problem the classpath metadata exists to prevent.Default it to the value of the common sources IC property instead, so that enabling common sources IC also enables the mechanism that makes it correct. The internal property still wins when set explicitly, so it remains a kill switch for turning the metadata off on its own.
^KT-88763 Fixed