Conversation
ndkoval
requested changes
Dec 6, 2020
Collaborator
ndkoval
left a comment
ndkoval
left a comment
There was a problem hiding this comment.
Good job! I've reviewed a part of PR now, will review the rest later. Please look at the comments in the meanwhile.
There are also two questions:
- What does "easy part" in the PR title mean?
- Is there still any code in Java?
|
|
||
| import java.lang.annotation.Inherited | ||
| import java.lang.annotation.Repeatable | ||
| import java.lang.annotation.Retention |
Collaborator
There was a problem hiding this comment.
Please configure annotations written in Kotlin with the mechanism provided by Kotlin
Contributor
Author
There was a problem hiding this comment.
Repeatable annotation from java can't be replaced by kotlin's one
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/ByteGen.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/DoubleGen.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/DoubleGen.kt
Outdated
Show resolved
Hide resolved
src/jvm/main/org/jetbrains/kotlinx/lincheck/paramgen/DoubleGen.kt
Outdated
Show resolved
Hide resolved
Krock21
changed the title
Krock21
force-pushed
the
java-to-kotlin
branch
from
da6b5c6 to
ec0217d
Compare
# Conflicts: # src/jvm/main/org/jetbrains/kotlinx/lincheck/CTestStructure.java # src/jvm/main/org/jetbrains/kotlinx/lincheck/runner/ParallelThreadsRunner.kt # src/jvm/main/org/jetbrains/kotlinx/lincheck/strategy/managed/ManagedStrategy.kt # src/jvm/test/org/jetbrains/kotlinx/lincheck/test/representation/AFUCallRepresentationTest.kt
… type from Class to KClass
…rifierClass, ExecutionGeneratorClass
# Conflicts: # src/jvm/main/org/jetbrains/kotlinx/lincheck/Utils.kt
…:locfree::spsc_queue test. Add folly [SM]P[SM]CQueue tests
…tion from HashMap)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.