Skip to content

Fix variable arguments on RedisCluster::rawCommand() #1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

wutsch0
Copy link
Contributor

@wutsch0 wutsch0 commented Apr 16, 2025

RedisCluster->rawCommand() method stub currently indicated that exactly 3 parameters would be required, but it actually requires 2 or more arguments

Code like

$redisCluster->rawCommand($key, 'expire', $key, $timeout, $mode);

gets highlighted with inspection warning

Method RedisCluster::rawCommand() invoked with 5 parameters, 3 required

although perfectly valid. Note that the original method name is not camelCase but all lower case as well (verified via reflection)

See the official phpredis stub for comparison.

This PR addresses WI-81080

@isfedorov isfedorov merged commit 211faef into JetBrains:master Apr 22, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants