Conversation
Codecov Report
@@ Coverage Diff @@
## master #143 +/- ##
=========================================
Coverage 25.26% 25.26%
Complexity 63 63
=========================================
Files 132 132
Lines 3903 3903
Branches 408 408
=========================================
Hits 986 986
Misses 2896 2896
Partials 21 21 Continue to review full report at Codecov.
|
SerVB
left a comment
SerVB
left a comment
There was a problem hiding this comment.
Cool but let's improve documentation a bit.
| Safari is not supported due to restrictions on clipboard access. | ||
| Also site requires secure context support. | ||
|
|
||
| Fallback implementation uses ["paste" listener](https://developer.mozilla.org/en-US/docs/Web/API/Element/paste_event). So clipboard is updated on the server only if you invoke that listener, for example, by hitting Ctrl+V or Ctrl+Shift+V. **If you have an application on the server side with a "paste" button, a click on it can paste outdated information unless the listener wasn't invoked**. |
There was a problem hiding this comment.
Is it really "fallback"? Looks like it's still always invoked when we paste, so we just update the clipboard without need. It can be improved, let's add todo in code or comment in documentation.
There was a problem hiding this comment.
without need
It is still needed in case we copy on the same page
|
|
||
| We implement it on the client side via setting ["paste" listener](https://developer.mozilla.org/en-US/docs/Web/API/Element/paste_event). So clipboard is updated on the server only if you invoke that listener, for example, by hitting Ctrl+V or Ctrl+Shift+V. **If you have an application on the server side with a "paste" button, a click on it can paste outdated information unless the listener wasn't invoked**. | ||
| We implement it on the client side by reading clipboard contents when the browser tab is activated, then sending to the server. | ||
| This allows a pretty seamless user experience. |
There was a problem hiding this comment.
It seems we still don't support a scenario when another app changes clipboard without activation of our browser tab. This case is rare (probably some special software) but I think we could mention that.
There was a problem hiding this comment.
Do you mean the situation when clipboard is changed in background while user uses projected IDE in active browser tab?
There was a problem hiding this comment.
Okay, I assume the silence means yes
3 participants
No description provided.