[cherrypick] 253 introducing pom for internal dependencies #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ✨ QD-11135 Add intellij-report-converter as downloadable from maven repo * ✨ QD-11135 Removed last traces of intellij-report-converter from TC * ✨ QD-11135 Moving resource dependencies to pom.xml to allow dependabot to take care of updates * ✨ QD-11135 Added comment explaining the pom.xml file * ✨ QD-11135 Co-pilot code review (cherry picked from commit 6631e73)
…dates (#823) * ⬆️ QD-12983: Bump the dependencies group across 1 directory with 2 updates Bumps the dependencies group with 2 updates in the /internal/tooling directory: org.jetbrains.qodana:publisher-cli and org.jetbrains.qodana:qodana-fuser. Updates `org.jetbrains.qodana:publisher-cli` from 3.0.11 to 3.0.12 Updates `org.jetbrains.qodana:qodana-fuser` from 1.0.26 to 1.0.28 --- updated-dependencies: - dependency-name: org.jetbrains.qodana:publisher-cli dependency-version: 3.0.12 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies - dependency-name: org.jetbrains.qodana:qodana-fuser dependency-version: 1.0.28 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies ... Signed-off-by: dependabot[bot] <[email protected]> * rerun checks --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jakub Andrzejewski <[email protected]> (cherry picked from commit 76061b3)
… 0.11.76 to 0.11.76.1 in /internal/tooling in the dependencies group (#824) * ⬆️ QD-12983: Bump org.jetbrains.qodana:intellij-report-converter Bumps the dependencies group in /internal/tooling with 1 update: org.jetbrains.qodana:intellij-report-converter. Updates `org.jetbrains.qodana:intellij-report-converter` from 0.11.76 to 0.11.76.1 --- updated-dependencies: - dependency-name: org.jetbrains.qodana:intellij-report-converter dependency-version: 0.11.76.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: dependencies ... Signed-off-by: dependabot[bot] <[email protected]> * rerun checks --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jakub Andrzejewski <[email protected]> (cherry picked from commit e6de200)
bonepl
requested review from
PetrovMikhail,
avafanasiev,
ikhromova and
ivan-orekhov
Qodana for Go36 new problems were found
☁️ View the detailed Qodana report Contact Qodana teamContact us at [email protected]
|
avafanasiev
approved these changes
Jan 30, 2026
ivanovec
reviewed
Jan 30, 2026
tooling/download-resource.go
Outdated
| } | ||
|
|
||
| func downloadFile(url, dest string) error { | ||
| resp, err := http.Get(url) |
Collaborator
There was a problem hiding this comment.
Shouldn't we use a timeout? The Get method can hang indefinitely
ivanovec
reviewed
Jan 30, 2026
tooling/download-resource.go
Outdated
| dep.Version, | ||
| ) | ||
|
|
||
| destFile := filepath.Join(".", dep.ArtifactID+".jar") |
Collaborator
There was a problem hiding this comment.
It’s better to sanitize ArtifactID (and other path-related fields like GroupID or Version) to prevent potential Path Traversal. While not critical in our current setup, security team will likely flag this during the next review
ikhromova
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Merge pom.xml versioning for internal dependencies to 253
Types of changes
Checklist