Skip to content

Psi/Record: fix for private constructors #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DedSec256 merged 2 commits into from
Nov 19, 2025
Merged

Psi/Record: fix for private constructors #1009

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dc6f0e
Psi/Record: fix for private constructors
DedSec256 Nov 19, 2025
771373c
test
DedSec256 Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...Sharp/FSharp.Psi/src/Impl/DeclaredElement/CompilerGenerated/FSharpGeneratedConstructor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ public override DeclaredElementType GetElementType() =>

public override IType ReturnType => PredefinedType.Void;

public override AccessRights GetAccessRights() =>
ContainingType.GetRepresentationAccessRights();

public bool IsDefault => false;
public bool IsParameterless => false;
Expand Down
7 changes: 4 additions & 3 deletions ReSharper.FSharp/test/data/cache/csharpResolve/Records 09 - Private representation.gold
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@
{
public Class1()
{
var r = new Module.R(1);
var field = r.|Field|(0);
var r = new Module.|R|(0)(1);
var field = r.|Field|(1);
Copy link
Member

@auduchinok auduchinok Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would also be cool to replace var with R to see if there are any errors reported on the type name.

}
}

---------------------------------------------------------
(0): ReSharper Underlined Error Highlighting: Cannot access internal property 'Field' here
(0): ReSharper Underlined Error Highlighting: Cannot access internal constructor 'R(int)' here
(1): ReSharper Underlined Error Highlighting: Cannot access internal property 'Field' here
M:Module.R.#ctor(System.Int32)
P:Module.R.Field
Loading