Open
Conversation
d8cfae9 to
12ef383
Compare
Member
|
@DedSec256 What's the state here? |
Collaborator
Author
|
@auduchinok, I'll try to finish it soon |
12ef383 to
916adf4
Compare
Member
|
@DedSec256 What do you think about splitting getting the parameter nodes and getting their names into separate APIs? Maybe something like this:
The current API does two unrelated enough things and it doesn't seem right. |
Member
|
A side note: we should try to build common interfaces that would remove this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.