Frontend/Typing Assists: initital support for 'Enter' in sync with backend #829
Conversation
DedSec256
force-pushed
the
ber.a/frontendTypingAssist
branch
from
f9943a8 to
82f4e8d
Compare
DedSec256
force-pushed
the
ber.a/frontendTypingAssist
branch
from
dae6bc1 to
3b625d2
Compare
| ) | ||
|
|
||
| override fun isApplicable(testCase: String) = | ||
| testCase.startsWith("Enter") |
There was a problem hiding this comment.
Is this check actually required? Can we check tests instead, like in isSupported?
There was a problem hiding this comment.
Test cases use the ReSharper typing assist specifying format, which the IntelliJ IDEA infrastructure does not understand. In this PR, I am currently using the hardcoded IdeActions.Enter action. It's possible to write separate logic that would retrieve the comment specifying the key press/action from the file and convert it to the IntelliJ IDEA format; this would eliminate the need to check isApplicable. But it hasn't been done yet.
| abstract fun isApplicable(sourceFile: String): Boolean | ||
| abstract fun isSupported(sourceFile: String): Boolean |
There was a problem hiding this comment.
Why do we need two methods here?
There was a problem hiding this comment.
The idea is to use the first method to select from all tests those intended for our scenario (for example, Enter).
The second method allows grouping available tests into those that are supported and those that are not.
Those that are not supported will fail if they begin to be supported.
| val HighlighterIterator.tokenTypeSafe: IElementType? | ||
| get() = if (this.atEnd()) null else this.tokenType | ||
|
|
||
| // TODO: Move to the platform |
There was a problem hiding this comment.
Why not do it right away? Isn't there anything like this already?
There was a problem hiding this comment.
This exists within the C++ frontend implementation and is not in the common code. It needs to be generalized because there are some API differences and moved to a common module. I'm working on this, and one day this code will be removed from the plugin.
| require(currTokenText.length >= minimumCommentLength) | ||
| { "Expected either a doc comment or non-empty line comment" } |
There was a problem hiding this comment.
Shouldn't it be something like this? I'm not sure about Kotlin style guides.
| require(currTokenText.length >= minimumCommentLength) | |
| { "Expected either a doc comment or non-empty line comment" } | |
| require(currTokenText.length >= minimumCommentLength) { | |
| "Expected either a doc comment or non-empty line comment" | |
| } |
There was a problem hiding this comment.
I'm a simple man -- I press Reformat code -> it formats. I'll check again.
| @@ -262,6 +265,10 @@ tasks { | |||
|
|
|||
| named<Test>("test") { | |||
| dependsOn(parserTest) | |||
| classpath -= classpath.filter { | |||
| (it.name.startsWith("localization-") && it.name.endsWith(".jar")) // TODO[#478]: https://youtrack.jetbrains.com/issue/IJPL-178084/External-plugin-tests-break-due-to-localization-issues | |||
| || it.name == "cwm-plugin.jar" // TODO[#479]: Check after 251 EAP5 release | |||
There was a problem hiding this comment.
It fixed just recently, yes.
ForNeVeR/AvaloniaRider@eac36a3
No description provided.