Lexer: Support #warnon #997
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DedSec256
force-pushed
the
ber.a/nowarn-warnon
branch
from
462c19b to
610bdf8
Compare
auduchinok
reviewed
Nov 21, 2025
| FSharpIdentifierToken(type:IDENTIFIER, text:Module) | ||
| NewLine(type:NEW_LINE, text:\n) spaces:"\n" | ||
| NewLine(type:NEW_LINE, text:\n) spaces:"\n" | ||
| FSharpWarningDirective |
Member
There was a problem hiding this comment.
Looking at this dump, I'd expect that the directive would be placed inside the module, at least for the top level ones. Are the any pros/cons?
Contributor
Author
There was a problem hiding this comment.
Oh, in FCS it is implemented in a lexer by analogy with
module M
// AHere, the entire module in the tree is only the first line, since it does not contain any elements. Therefore, the module does not contain the directive token (as well as the line comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.