ANGLE support #1017

Alovchin91 · 2025-01-30T09:41:13Z

This change adds ANGLE renderer support to Skiko.

ANGLE project translates OpenGL ES API calls to the native platform's graphics API. This is mostly useful on Windows where ANGLE provides the Direct3D 11 backend.

Right now, there is a gap in Skiko's graphics support. On Windows ARM, Skia doesn't support OpenGL yet. At the same time, some GPUs, like Parallels or VMware virtual GPUs, don't support DirectX 12. This means Skiko falls back to the slow software rendering on those GPUs. ANGLE solves this problem by providing an easy-to-use DirectX 11 backend.

In addition, ANGLE is used by Chromium-based browsers and apps, so we expect it to be more stable than Skia's DirectX backend.

skiko/buildSrc/src/main/kotlin/properties.kt

igordmn · 2025-01-31T13:02:07Z

skiko/build-with-local-skia.sh

@@ -43,7 +43,7 @@ case $SKIA_TARGET in
    ;;


It will be good if we can include Angle as a jar via skiko-awt-runtime-angle-$platform

Let me see if I can figure this out

I have done this in the new branch. It also downloads the binaries from https://github.com/JetBrains/angle-pack/releases

skiko/build-with-local-skia.sh

skiko/src/jvmMain/kotlin/org/jetbrains/skiko/SkikoProperties.kt

skiko/src/awtMain/kotlin/org/jetbrains/skiko/redrawer/AngleRedrawer.kt

skiko/src/awtMain/cpp/windows/AngleSupport.cc

skiko/src/commonMain/kotlin/org/jetbrains/skiko/AngleSupport.kt

skiko/src/awtMain/kotlin/org/jetbrains/skiko/redrawer/AngleRedrawer.kt

igordmn · 2025-02-19T22:04:09Z

skiko/src/awtMain/cpp/windows/AngleSupport.cc

+        TCHAR libEGL[MAX_PATH] = TEXT("");
+        TCHAR libGLESv2[MAX_PATH] = TEXT("");
+        HMODULE hmodule = nullptr;
+        THROW_IF_NULL(GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS | GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT,


Where should I put dll's in case I run a Java library?

Worked only after I packaging via jpackage, and placing the libs near the jars. But not sure how it should work without it, for example, when I run via Gradle that defines a classpath in different cached folders.

I'm not sure how to answer this. This code looks for the ANGLE libraries in the exact same directory as skiko-windows-<ARCH>.dll for security (because we don't want to load it from a random place in the system). Does Skiko DLL get extracted somewhere in the Gradle case?

Does Skiko DLL get extracted somewhere in the Gradle case

Yes, it has 3-way logic:

look in the skiko.library.path

look in the jar resources, unpack it to ~/.skiko/hash

look in %java.home%

Besides, it checks if a second class loader tries to load the same library and copies it if it does (needed for plugins that use different Skiko versions).

I refactored it in the branch by reusing the existed logic. Please look and verify if it works for your case (it should be loaded the same way as Skiko does).

I implemented it in #1082, it rewrites the current PR logic and reuses the logic above

skiko/src/jvmMain/kotlin/org/jetbrains/skiko/SkikoProperties.kt

skiko/src/awtMain/kotlin/org/jetbrains/skiko/redrawer/AngleRedrawer.kt

igordmn · 2025-02-19T23:40:12Z

skiko/src/awtMain/cpp/windows/AngleRedrawer.cc

+            AngleDevice *angleDevice = new AngleDevice();
+            angleDevice->window = hwnd;
+            angleDevice->device = hdc;
+            angleDevice->display = getAngleEGLDisplay(angleDevice->device);


We should test how if FPS always equals refresh rate when we move a window from one display to another with different refresh rate (after removing dwmFlush)

I tested on a Windows laptop with integrated AMD card:

it doesn't change FPS between 120hz and 165hz displays

though, the DIRECT3D/OPENGL don't change it either (previously on a different machine it changed it correctly)

checking it on one monitor and just changing the refresh rate in the system settings changes the FPS correctly

So, we can assume, that it probably behaves correctly and any deviation is probably system related

I would probably open an issue to see how it behaves when the system switches between a discrete and an integrated GPU, and also to make sure the window created by Skiko has the CS_OWNDC flag set.

https://youtrack.jetbrains.com/projects/SKIKO/issues/SKIKO-1043/Investigate-behavior-of-switching-to-integrated-discrete-GPU-during-application-running

https://youtrack.jetbrains.com/issue/SKIKO-1044/ANGLE-renderer.-Support-skiko.gpu.priority

skiko/src/awtMain/cpp/windows/AngleSupport.cc

This fixes the black bars issue when resizing a window

skiko/src/jvmMain/kotlin/org/jetbrains/skiko/SkikoProperties.kt

igordmn

It is good to merge after you review my last commits.

I also made #1082 for Compose use cases, please review it as well, as it affects your use case.

skiko/src/awtMain/kotlin/org/jetbrains/skiko/redrawer/AngleRedrawer.kt

skiko/src/jvmMain/kotlin/org/jetbrains/skiko/SkikoProperties.kt

skiko/src/awtMain/cpp/windows/AngleSupport.cc

skiko/src/awtMain/kotlin/org/jetbrains/skiko/redrawer/AngleRedrawer.kt

igordmn · 2025-08-13T12:09:13Z

skiko/build-with-local-skia.sh

@@ -43,7 +43,7 @@ case $SKIA_TARGET in
    ;;


I have done this in the new branch. It also downloads the binaries from https://github.com/JetBrains/angle-pack/releases

igordmn · 2025-08-13T12:12:06Z

skiko/src/awtMain/cpp/windows/AngleSupport.cc

+        TCHAR libEGL[MAX_PATH] = TEXT("");
+        TCHAR libGLESv2[MAX_PATH] = TEXT("");
+        HMODULE hmodule = nullptr;
+        THROW_IF_NULL(GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS | GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT,


Does Skiko DLL get extracted somewhere in the Gradle case

Yes, it has 3-way logic:

look in the skiko.library.path

look in the jar resources, unpack it to ~/.skiko/hash

look in %java.home%

Besides, it checks if a second class loader tries to load the same library and copies it if it does (needed for plugins that use different Skiko versions).

I refactored it in the branch by reusing the existed logic. Please look and verify if it works for your case (it should be loaded the same way as Skiko does).

igordmn · 2025-08-13T17:34:06Z

skiko/src/awtMain/cpp/windows/AngleRedrawer.cc

+            AngleDevice *angleDevice = new AngleDevice();
+            angleDevice->window = hwnd;
+            angleDevice->device = hdc;
+            angleDevice->display = getAngleEGLDisplay(angleDevice->device);


I tested on a Windows laptop with integrated AMD card:

it doesn't change FPS between 120hz and 165hz displays

though, the DIRECT3D/OPENGL don't change it either (previously on a different machine it changed it correctly)

checking it on one monitor and just changing the refresh rate in the system settings changes the FPS correctly

So, we can assume, that it probably behaves correctly and any deviation is probably system related

skiko/src/jvmMain/kotlin/org/jetbrains/skiko/SkikoProperties.kt

igordmn · 2025-08-13T18:05:27Z

skiko/src/awtMain/cpp/windows/AngleSupport.cc

+        TCHAR libEGL[MAX_PATH] = TEXT("");
+        TCHAR libGLESv2[MAX_PATH] = TEXT("");
+        HMODULE hmodule = nullptr;
+        THROW_IF_NULL(GetModuleHandleEx(GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS | GET_MODULE_HANDLE_EX_FLAG_UNCHANGED_REFCOUNT,


I implemented it in #1082, it rewrites the current PR logic and reuses the logic above

igordmn · 2025-08-14T13:01:26Z

@Alovchin91 approved in DM the last my commits. I approved the original commits

An addition to [the feature PR](#1017) that allows including ANGLE the same way as Skiko native libraries included: - unpack it from an additional jar `org.jetbrains.skiko:skiko-awt-runtime-angle-$target:$version` - find them in `skiko.library.path` directoty (a system property) - find them in `java.home` It reuses the same logic that is used to load `Skiko.dll`. Currently only Windows supported, the same way as in the original PR. No CI changes needed, as building of this jar is added as a dependency for `publishSkikoJvmRuntimeWindowsX64PublicationToComposeRepoRepository`/`publishSkikoJvmRuntimeWindowsArm64PublicationToComposeRepoRepository` ## Testing Manually with `skiko.rendering.angle.enabled` true/false on SkikoAwtSample. ## Release Notes (Skiko) ### Features - Desktop A new experimental renderer is introduced for Windows. It uses [the ANGLE library](https://github.com/google/angle) which has proven to be stable because it is used inside Chromium, compared to the `DIRECT3D` renderer that has issues on a few machines. Note that `ANGLE` still uses `DIRECT3D` API under the hood. 1. Add this to the code to enable it: ``` System.setProperty("skiko.rendering.angle.enabled", "true") ``` 2. Add the ANGLE library into the dependencies: - If you use Gradle: ``` if (System.getProperty("os.name").startsWith("Win")) { implementation("org.jetbrains.skiko:skiko-awt-runtime-angle-$target:$version") } ``` - If you set `skiko.library.path`. Extract `libEGL.dll`, `libGLESv2.dll` from https://github.com/JetBrains/angle-pack/releases into this directory. ## Release Notes (Compose) ### Features - Desktop N/A Until we specify how to match Skiko and Compose versions, or include it in Compose, it is a Skiko-only experimental feature. Some projects can include Skiko directly, it should work, but not supported as a Compose feature.

igordmn self-requested a review January 30, 2025 10:50

igordmn reviewed Jan 31, 2025

View reviewed changes

igordmn self-requested a review January 31, 2025 13:38

Alovchin91 force-pushed the alovchin/angle branch 4 times, most recently from b951351 to 87790e5 Compare February 7, 2025 15:34

Alovchin91 marked this pull request as ready for review February 7, 2025 15:42

Alovchin91 force-pushed the alovchin/angle branch from 87790e5 to 4cf4430 Compare February 12, 2025 10:37

Alovchin91 mentioned this pull request Feb 12, 2025

Enable ANGLE support in Skia-pack JetBrains/skia-pack#65

Draft

igordmn mentioned this pull request Feb 13, 2025

Add a thin wrapper around Skia's PDF backend #775

Open

igordmn reviewed Feb 20, 2025

View reviewed changes

Alovchin91 added 8 commits March 28, 2025 14:42

Add infrastructure to support ANGLE in Skiko

e56be1e

Implement AngleRedrawer and AngleContextHandler

dd7191c

Load ANGLE libraries by full path

473cc8f

Recreate the surface instead of resizing

bbb615a

This fixes the black bars issue when resizing a window

Use eglSwapInterval instead of DwmFlush

22826e6

Use RenderException instead of AngleRedrawerException

c34a87d

Don't make ANGLE the default API on Windows since it is optional

acb347e

Address review comments

bb7e559

Alovchin91 force-pushed the alovchin/angle branch from 4cf4430 to bb7e559 Compare March 28, 2025 13:45

Alovchin91 commented Mar 28, 2025

View reviewed changes

skiko/src/jvmMain/kotlin/org/jetbrains/skiko/SkikoProperties.kt Outdated Show resolved Hide resolved

igordmn added 3 commits July 14, 2025 11:40

Return check "adapterName != null &&"

7c546ba

Introduce skiko.rendering.angle.enabled

04d54c2

Merge branch 'master' into alovchin/angle

72b33cb

igordmn mentioned this pull request Aug 13, 2025

Pack ANGLE into a separate jar #1082

Merged

igordmn reviewed Aug 13, 2025

View reviewed changes

igordmn approved these changes Aug 14, 2025

View reviewed changes

igordmn merged commit eda88cd into JetBrains:master Aug 14, 2025
7 checks passed

Alovchin91 deleted the alovchin/angle branch August 14, 2025 13:04

ANGLE support #1017

ANGLE support #1017

Uh oh!

Conversation

Alovchin91 commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Alovchin91 Jan 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

igordmn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

igordmn commented Aug 14, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Alovchin91 commented Jan 30, 2025 •

edited

Loading

Alovchin91 Jan 31, 2025 •

edited

Loading