Implement SkImages::AdoptTextureFrom bindings #1019
Conversation
Tested-by: Lunasa <[email protected]>
MatkovIvan
left a comment
MatkovIvan
left a comment
There was a problem hiding this comment.
Aside from JNI, it should contain K/N bindings to work outside JVM too
|
I've implemented the requested changes. |
MatkovIvan
left a comment
MatkovIvan
left a comment
There was a problem hiding this comment.
Thanks for implementing the missing part.
Currently I'm not sure that creating a new GrBackendTexture should be a part of Image API, but I'm OK to leave this part as TODO for later.
PS I'll be on vacation next week so cc @igordmn for taking care of it
| GrBackendTexture backendTexture = GrBackendTextures::MakeGL( | ||
| width, | ||
| height, | ||
| skgpu::Mipmapped::kYes, |
There was a problem hiding this comment.
Such a thing shouldn't be hardcoded
There was a problem hiding this comment.
Let's provide it as a parameter (boolean suffice if it has 2 options)
| textureInfo.fTarget = static_cast<GrGLenum>(target); | ||
| textureInfo.fFormat = static_cast<GrGLenum>(format); | ||
|
|
||
| GrBackendTexture backendTexture = GrBackendTextures::MakeGL( |
There was a problem hiding this comment.
It seems that we need to expose this separately and pass it as an argument
There was a problem hiding this comment.
It is a GL object that is used in a non-GL method. Because of that we have to move it out of this method and create a real BackendTexture kotlin class with BackendTexture.MakeGL function.
|
@igordmn Any idea when this will be reviewed? |
| GrBackendTexture backendTexture = GrBackendTextures::MakeGL( | ||
| width, | ||
| height, | ||
| skgpu::Mipmapped::kYes, |
There was a problem hiding this comment.
Let's provide it as a parameter (boolean suffice if it has 2 options)
| textureInfo.fTarget = static_cast<GrGLenum>(target); | ||
| textureInfo.fFormat = static_cast<GrGLenum>(format); | ||
|
|
||
| GrBackendTexture backendTexture = GrBackendTextures::MakeGL( |
There was a problem hiding this comment.
It is a GL object that is used in a non-GL method. Because of that we have to move it out of this method and create a real BackendTexture kotlin class with BackendTexture.MakeGL function.
| return Image(ptr) | ||
| } | ||
|
|
||
| /** Creates GPU-backed [org.jetbrains.skia.Image] from backendTexture associated with context. |
There was a problem hiding this comment.
- Please use KDoc format of the comment:
/**
*
*
*/
- describe the parameters as in the original documentation in Skia
### New: (related #1019) 1. Adds bindings to GrBackendTextures::MakeGL 2. Adds bindings to SkImages::AdoptTextureFrom 3. Adds bindings to GrBackendTextures::GLTextureParametersModdified ### Changes in build scripts: (related #742) 1. Add file paths treating if building on Windows machine 2. Use "emcc.bat" instead of "emcc" if building on Windows machine, as described on Emscripten website ### Use-case: Allows skia to draw images, rendered externally on gpu. Compose would benefit greatly, allowing to embed VideoPlayer or Browser without any friction or need to use Swing.
3 participants
I've tested it and it works completely fine under OpenGL.