Build skiko with skia@m132 #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eymar
reviewed
Feb 5, 2025
Member
eymar
left a comment
eymar
left a comment
There was a problem hiding this comment.
Looks good to me.
I think the failed CI on some targets is due to outdated imports?
| #include "SkRect.h" | ||
| #include "common.h" | ||
|
|
||
| using SkRuntimeShaderBuilder = SkRuntimeEffectBuilder; |
Member
There was a problem hiding this comment.
In Jvm bindings it was replaced directly to SkRuntimeEffectBuilder.
Is it possible to replace here too, for consistency?
Contributor
Author
There was a problem hiding this comment.
@eymar sure, it just that introducing alias was minimal intrusion but you are right - it's better to be homomorphic in that aspect, so let me do it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.