Remove BreakIterator.clone() method #1024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is broken on JVM and seemingly leads to a use-after-free behaviour
MatkovIvan
approved these changes
Feb 11, 2025
Member
MatkovIvan
left a comment
MatkovIvan
left a comment
There was a problem hiding this comment.
This is a breaking change and will require bumping Skiko version to 0.9.0.
We're still in 0.x versions and usually do not bump the second version because of removing some minor APIs. So I don't mind to bump (it doesn't really matter), but it's not about "will require"
igordmn
approved these changes
Feb 11, 2025
Collaborator
I am more for bumping because of changing the compiler on one of the platforms |
igordmn
pushed a commit
that referenced
this pull request
Feb 12, 2025
Official Skia documentation suggests that it's [_highly recommended_](https://skia.org/docs/user/build/#highly-recommended-build-with-clang-cl) to build Skia with Clang-CL on Windows, and that this dramatically improves Skia performance with Software rendering and in other areas. This corresponds with my experience, so here it is. Related Skia-pack PR: JetBrains/skia-pack#64 Prerequisite: #1024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is split-off from and is a prerequisite of Clang-cl PR: #1020
BreakIterator.clone() is broken on JVM and seemingly leads to a use-after-free behaviour. Clang-cl makes this issue more visible, likely due to address sanitisation.
Explanation why it is deleted in an internal channel: https://jetbrains.slack.com/archives/C02DDNREC77/p1738678000232729
breakIteratorCloneTestis failing with an access violation in Debug mode with additional checks, so using it wasn't safeThis is a breaking change and will require bumping Skiko version to 0.9.0.