Fix bindings for PixelRef #1149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
approved these changes
Jan 27, 2026
Member
MatkovIvan
left a comment
MatkovIvan
left a comment
There was a problem hiding this comment.
LGTM, thanks
Triggered CI separately:
https://github.com/JetBrains/skiko/actions/runs/21400904845
https://github.com/JetBrains/skiko/actions/runs/21400896168
MatkovIvan
added a commit
to JetBrains/compose-multiplatform-core
that referenced
this pull request
Jan 29, 2026
Fixes [CMP-9705](https://youtrack.jetbrains.com/issue/CMP-9705) Update skiko to 0.9.43 ## What's Changed in `skiko` - JetBrains/skiko#1149 - JetBrains/skiko#1140 - JetBrains/skiko#1052 **Full Changelog**: http://github.com/JetBrains/skiko/compare/v0.9.41...v0.9.43 (no customer-facing issues/notes from Compose POV) ## Release Notes N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes https://youtrack.jetbrains.com/issue/SKIKO-996
The PixelRef bindings have two mistakes in them:
rowBytesis defined as aNativePointer, whereas it is actually an integer with the number of bytes per row. This is the same asBitmap::rowBytes.pixelsproperty that actually returns a pointer to the pixel data.See: https://api.skia.org/classSkPixelRef.html