Refactor local Skia build to Gradle/Kotlin#1163
Merged
MatkovIvan merged 2 commits intomasterfrom Feb 16, 2026
Merged
Conversation
Replace bash logic with type-safe Gradle tasks: - Add SkiaTarget enum for platform mapping - Add BuildLocalSkiaTask for build orchestration - Add SkikoGradleProperties for shared property names - Add Gradle tasks: buildSkiaLocally, detectSkiaDir, printSkiaVersion - Improve build-with-local-skia.sh structure and error handling Benefits: - Type-safe configuration with compile-time validation - Reuses existing Gradle infrastructure - IDE support (autocomplete, navigation, refactoring) - Better error handling and logging - Reduced bash script complexity
eymar
reviewed
Feb 16, 2026
Address all code review issues identified in the Gradle/Kotlin refactoring: Critical fixes: - Add validation for skia-pack directory structure and Python scripts - Improve git checkout error handling with explicit failures - Replace subprocess Gradle invocation with separate build/publish steps Improvements: - Separate skia.pack.dir and skia.dir parameters for clarity - Make version format validation fail-fast instead of warning
MatkovIvan
force-pushed
the
ivan.matkov/build-local-skia-gradle
branch
from
f5abcde to
ceb63c8
Compare
eymar
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously:
SKIA_VERSIONseparately fromgradle.properties, leading to version mismatchesSKIA_TARGETdefault toiosSim, requiring manual override on non-macOS systemsThis change:
skiaVersionFromEnvOrPropertiesproperty andprintSkiaVersiontask. The bash script now queries Gradle for the version instead of maintaining its own default.hostOs.id) instead of hardcodediosSim.BuildLocalSkiaTaskthat handles Python build script invocation, architecture detection, and validation.SkiaTargetenum centralizing platform-specific Gradle flags and architecture mappings.Usage