Draft
Conversation
Introduce a VCS provider abstraction layer and implement Perforce support alongside the existing Git integration. This enables the CLI to work with Perforce workspaces for branch detection, local changes, and personal builds. Changes: - VCS provider interface (VCSProvider) with Git and Perforce implementations - Auto-detection of VCS type (Git repo vs Perforce workspace) - VCS root CRUD API methods (create, read, list, delete, attach) - Perforce-aware branch/revision formatting in build triggers and change display - Support for `--local-changes p4` to upload Perforce pending changelists - Integration tests with p4d container for VCS root operations - Unit tests for all VCS providers and API methods https://claude.ai/code/session_01Buy3ZEvVTWwhkQHU4H442q
- Consolidate 4 DetectVCS() calls in runRunStart into 1 - Unify loadLocalChanges through VCS provider (git/p4/auto all use same path) - Remove VCSBranchFormatter closure from API struct (heuristic handles both VCS types) - Add 10s timeout to all p4 subprocess calls via exec.CommandContext - Extract p4Output/p4Run/p4ZtagField helpers to DRY up ztag parsing - Remove dead code: getPerforcePort(), unused perforceTestEnv fields - Replace time.Sleep with readiness polling in p4d integration test - Fix populateP4Depot to propagate errors instead of swallowing - Fix url parameter shadow in NewGitVcsRootProperties https://claude.ai/code/session_01Buy3ZEvVTWwhkQHU4H442q
Remove AI-generated doc comments, unused p4Run function, and compact single-line interface delegations for cleaner review. https://claude.ai/code/session_01Buy3ZEvVTWwhkQHU4H442q
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Design Decisions
Example
Test Plan
go test ./...)golangci-lint run)