Improve Qodana workflow with better error handling and unique branch names #630
+46
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…names - Add QODANA_VERSION env var to centralize version management - Add shell: bash and set -euo pipefail for proper error handling - Use unique branch names with SHA and run number suffix to avoid conflicts - Sanitize branch names to prevent special character issues - Change --force to --force-with-lease for safer pushing - Output fixes info to GITHUB_STEP_SUMMARY for visibility - Quote GITHUB_OUTPUT properly - Remove redundant condition checks Co-Authored-By: Claude Opus 4.5 <[email protected]>
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Qodana for JVM3 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The existing Qodana workflow had several code quality issues and potential failure modes:
Changes:
QODANA_VERSIONenv var to avoid version duplication between action and lintershell: bashandset -euo pipefailto all run steps for proper error handling--forceto--force-with-leaseto prevent overwriting others' changesGITHUB_STEP_SUMMARYfor better visibility$GITHUB_OUTPUTproperlygithub.event_name == 'workflow_dispatch'condition (already implied byRUN_CLEANUP)🤖 Generated with Claude Code