Limit Zulip build notifications to main branches only #631
+9
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add NOTIFICATION_BRANCHES env variable to configure which branches receive build failure/fix notifications (currently only 'develop'). - Add conditions to notify-failure and notify-fixed jobs to check branch membership and restrict to push events - Simplify branch name determination by removing merge_group handling - Make notification branch list easily configurable via JSON array
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Qodana for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
The env context is not available in job-level if conditions in GitHub Actions. Switch to vars.MAIN_BRANCHES which is accessible at job level. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently, Zulip build failure/fix notifications are sent for all branches, which can create noise and reduce the signal value of these notifications. Teams typically only need to be notified about build issues on main protected branches (like
developormain) rather than every feature branch.This change restricts notifications to only configured main branches, making the notification system more focused and useful.
Changes:
NOTIFICATION_BRANCHESenvironment variable at workflow level with a JSON array of branch names that should receive notifications (currently["develop"])notify-failurejob condition to check:push(not PR or merge queue)NOTIFICATION_BRANCHESlistnotify-fixedjob with the same conditionsmerge_grouphandling (no longer needed since notifications are restricted to push events)🤖 Generated with Claude Code