[repo-assist] fix(diff): add --no-pager and package header to git diff (#1243) - #2905
Merged
Jguer merged 3 commits intoJul 19, 2026
Merged
Conversation
Previously, each package's diff was shown via a separate `git diff` invocation with Show(), allowing git to invoke its own pager (e.g. less) independently for each package. This caused inconsistent pagination: large diffs opened a pager, small diffs scrolled past in the terminal. Changes: - Add --no-pager flag to git diff so git doesn't open its own pager per package; all diffs now stream consistently to stdout. - Print a package name header before each diff so users can easily identify which package each diff belongs to when reviewing multiple packages. Closes #1243 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
4 tasks
Jguer
marked this pull request as ready for review
July 18, 2026 23:59
Jguer
approved these changes
Jul 19, 2026
Jguer
deleted the
repo-assist/fix-issue-1243-diff-pagination-61a83cc10996b596
branch
July 19, 2026 00:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist.
Summary
Fixes the inconsistent pagination of PKGBUILD diffs when reviewing multiple packages (issue #1243).
Root cause:
showPkgbuildDiffscalledcmdBuilder.Show()with a baregit diffcommand for each package.gitby default invokes a pager (e.g.less) when output exceeds the terminal height, but does not invoke it for short diffs. This caused different packages to behave differently: large diffs openedlessindividually, small diffs just scrolled past.Changes
--no-pagerbeforediffin the git args. This prevents git from opening its own pager per package; all diffs now stream consistently to stdout regardless of length.==> Showing diff for <pkg>) before each diff. When reviewing multiple packages, users can now clearly see where each package's diff begins.Trade-offs
PAGER=lessor pipe yay through a pager. This is consistent, predictable behaviour compared to the current inconsistent per-diff paging.jguer/skip-confirmed-confirmsbranch exploring config-driven behaviour; the--no-pagerapproach is the simplest fix and doesn't conflict with that work.Test Status
"--no-pager"to an existing string slice and adding onelogger.Printlncall. Both are consistent with surrounding code patterns.Closes #1243
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
proxy.golang.orgSee Network Configuration for more information.
Add this agentic workflows to your repo
To install this agentic workflow, run