Skip to content

homing_override 'middle' fix with bltouch support - #1

Open
JiMcNulty wants to merge 1 commit into
v2.xfrom
JiMcNulty-patch-1
Open

homing_override 'middle' fix with bltouch support#1
JiMcNulty wants to merge 1 commit into
v2.xfrom
JiMcNulty-patch-1

Conversation

@JiMcNulty

Copy link
Copy Markdown
Owner

@Hr46ph

Hr46ph commented Apr 23, 2023

Copy link
Copy Markdown

I think it would be better to override these variables in printer.cfg below this section:

#############################################################################################################
### MACRO CONFIGURATION
### Configure the behavior of RatOS macros
#############################################################################################################
[gcode_macro RatOS]
...
# Safe home overrides for use with SuperPinda in EVA 2
variable_safe_home_x: 177.8
variable_safe_home_y: 162.0

I realize its not as neat and dynamic but changing home.cfg will risk it gets overwritten with updates from RatOS. I tried variations of {% set safe_home_x = (printer.toolhead.axis_maximum.x / 2) - probe_x_offset %} or variable_safe_home_x: (printer.toolhead.axis_maximum.x / 2) - probe_x_offset % but that doesn't seem to work at that place.

@JiMcNulty

Copy link
Copy Markdown
Owner Author

I think it would be better to override these variables in printer.cfg below this section:

#############################################################################################################
### MACRO CONFIGURATION
### Configure the behavior of RatOS macros
#############################################################################################################
[gcode_macro RatOS]
...
# Safe home overrides for use with SuperPinda in EVA 2
variable_safe_home_x: 177.8
variable_safe_home_y: 162.0

I realize its not as neat and dynamic but changing home.cfg will risk it gets overwritten with updates from RatOS. I tried variations of {% set safe_home_x = (printer.toolhead.axis_maximum.x / 2) - probe_x_offset %} or variable_safe_home_x: (printer.toolhead.axis_maximum.x / 2) - probe_x_offset % but that doesn't seem to work at that place.

Thanks for taking the time to help improve this!

I think that copying the entire [homing_override] to printer.cfg will work as you intended

@Hr46ph

Hr46ph commented Apr 23, 2023

Copy link
Copy Markdown

Yes, copying the entire macro will work, however it defeats the idea behind RatOS. The way they set it up is completely modular, so that you can override only the parts that you want to change. Taking that approach, when a RatOS dev would change something in their homing macro, you will get their updates without messing with your own overrides.

RatOS is really neat if you ask me! 😄

Edit: and seeing you have RatOS configs forked and Ratrig mods, you probably already knew all that 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants