Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I've switched the ANN search to the HNSW library which is faster.
I've also fixed a rare bug where a data point could disappear from the output (if all of its nearest neighbor had no shared nearest neighbor with it and if no point from which it is a nearest neighbor had a common nearest neighbor with it. Happened once in a 3,000,000+ dataset but I remember having encountered that bug before).
Would be good to a least merge the bug fix! It corresponds to the following code snippet from the phenograph.R file
Thanks!