ci: pin Store CLI to v0.4.2 now that the upload timeout bug is fixed - #96
Open
azchohfi wants to merge 1 commit into
Open
ci: pin Store CLI to v0.4.2 now that the upload timeout bug is fixed#96azchohfi wants to merge 1 commit into
azchohfi wants to merge 1 commit into
Conversation
STORE_CLI_VERSION sat on v0.4.1, the last release carrying microsoft/msstore-cli#162: --uploadTimeout was added with a CustomParser but no DefaultValueFactory, so omitting it left the value at default(long) -- 0 -- which became the Azure blob client's NetworkTimeout and cancelled every request immediately. #163 fixes that and shipped in v0.4.2 on 2026-09-02, so the pin advances and the comments stop describing a live bug. STORE_UPLOAD_TIMEOUT_SECONDS and the --uploadTimeout argument stay. They are no longer a workaround, but the value is still worth setting: the CLI sets no StorageTransferOptions, so an .appxupload under 256 MiB is uploaded as a single PUT and NetworkTimeout has to cover the entire transfer rather than one chunk. NativeAotSourceContractTests is updated to match the new pin. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: a33ffb27-8072-43c0-beb7-a7bc7e8e2229
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
STORE_CLI_VERSIONsat onv0.4.1, the last release carrying microsoft/msstore-cli#162. That is fixed by #163 and released in v0.4.2 on 2026-09-02, so the pin advances and the comments stop describing a live bug.This is deliberately not a revert of #92
#92 bundled three unrelated things: the timeout workaround, the
@v1.3→@v1.4action upgrade, and error-handling improvements (themsstore --versiongate, exit-code messages). Only the workaround framing and the pin change here — the action upgrade and the error handling are kept.STORE_UPLOAD_TIMEOUT_SECONDS: 900staysIt is no longer a workaround, but it is still worth setting.
AzureBlobManagercallsblobClient.UploadAsyncwithout settingStorageTransferOptions, so the SDK's default 256 MiBInitialTransferSizeapplies and an.appxuploadunder that size is uploaded as a single PUT.Retry.NetworkTimeouttherefore bounds the entire transfer rather than an individual chunk — so for a multi-archx86|x64|ARM64bundle the restored 100 s default would be a real risk, and it would fail in the same silentUploading Bundle to Azure blob: 0%shape that #162 produced.The validation block and the
--uploadTimeoutargument are therefore untouched.Test contract
NativeAotSourceContractTests.StoreRelease_UsesPrValidatedNativeAotWithoutHardwareDependencyasserts on the workflow's literal text, includingSTORE_CLI_VERSION: v0.4.1. That assertion is updated tov0.4.2in the same commit so the suite stays green. TheSTORE_UPLOAD_TIMEOUT_SECONDS: 900and'--uploadTimeout'assertions still hold unchanged.Net effect
Pin
v0.4.1→v0.4.2, two comment rewrites, one test assertion, one docs sentence. No behaviour change beyond the version bump.Sent as part of a sweep across the repos that referenced msstore-cli#162.