[Bug Fix] Proxy param & health check subprocess#92
[Bug Fix] Proxy param & health check subprocess#92Bounty-hunter wants to merge 1 commit intoJiusiServe:v0.9.1from
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Code Review
This pull request addresses a bug fix related to proxy parameters and enhances the health check subprocess. The changes include adding a FailureResponse to the disaggregated protocol, implementing health checks for the engine, and improving error handling during generation. Additionally, input validation and request ID handling have been improved in the proxy.py file.
4027a19 to
27c6e7a
Compare
|
This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you! |
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.