Skip to content

Fixed issue 93: https://github.com/JoanZapata/android-iconify/issues/93 #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chRyNaN wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed issue 93: https://github.com/JoanZapata/android-iconify/issues/93 #121

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fdd88d
Fixed issue 93: https://github.com/JoanZapata/android-iconify/issues/93
Sep 14, 2015
6da0580
Fixed mistakes.
Sep 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions android-iconify/src/main/java/com/joanzapata/iconify/IconDrawable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
import android.text.TextPaint;
import android.util.TypedValue;

import java.lang.Override;

import static android.util.TypedValue.COMPLEX_UNIT_DIP;

/**
Expand Down Expand Up @@ -33,6 +35,8 @@ public class IconDrawable extends Drawable {

private int alpha = 255;

private IconDrawable.ConstantState constantState;

/**
* Create an IconDrawable.
* @param context Your activity or application context.
Expand Down Expand Up @@ -66,6 +70,7 @@ private void init(Context context, Icon icon) {
paint.setUnderlineText(false);
paint.setColor(Color.BLACK);
paint.setAntiAlias(true);
constantState = new IconDrawable.ConstantState(this);
}

/**
Expand Down Expand Up @@ -196,6 +201,15 @@ public int getOpacity() {
return this.alpha;
}

/*
* Fixes problem with setIcon() method, issue found (and wrongfully closed) here:
* https://github.com/JoanZapata/android-iconify/issues/93
*/
@Override
public Drawable.ConstantState getConstantState(){
return constantState;
}

/**
* Sets paint style.
* @param style to be applied
Expand All @@ -218,4 +232,23 @@ private int convertDpToPx(Context context, float dp) {
COMPLEX_UNIT_DIP, dp,
context.getResources().getDisplayMetrics());
}

public static class ConstantState extends Drawable.ConstantState{
private Drawable drawable;

public ConstantState(Drawable drawable){
super();
this.drawable = drawable;
}

public Drawable newDrawable(){
return drawable;
}

public int getChangingConfigurations(){
return 0;
}

}

}