Skip to content

Support search icons and find similar icons#166

Open
baurine wants to merge 5 commits into
JoanZapata:masterfrom
baurine:feature/support_search
Open

Support search icons and find similar icons#166
baurine wants to merge 5 commits into
JoanZapata:masterfrom
baurine:feature/support_search

Conversation

@baurine
Copy link
Copy Markdown

@baurine baurine commented Apr 9, 2016

support search icons

the result screenshot:

1 pic_hd

2 pic_hd

@baurine baurine changed the title Feature/support search Support search icons Apr 9, 2016
baurine added 2 commits April 10, 2016 14:12
1. display "No match icons" when has no result

2. remove keyword length must more than 1 limitation
@keunes
Copy link
Copy Markdown

keunes commented Apr 10, 2016

Cool :)
Does it only search on the icon name, or can it also (be extendable and) search on 'tags'? If tags or sth aren't supported, it's hard to find all possibly relevant icons (eg would one find 'md-tap-and-play' if on searched for 'stream'?)

@baurine
Copy link
Copy Markdown
Author

baurine commented Apr 10, 2016

@keunes now it just support search by icon name. I also want to support search by tags, but it seems not very easy and can quick implement.

@baurine
Copy link
Copy Markdown
Author

baurine commented Apr 10, 2016

now support find similar icons when you click any icon.

the final screenshot:

00_search_fab

01_search

02_similar_icons

@baurine baurine changed the title Support search icons Support search icons and find similar icons Apr 10, 2016
@MarcinOrlowski
Copy link
Copy Markdown

@baurine Can you provide APK for easy test?

@baurine
Copy link
Copy Markdown
Author

baurine commented Apr 11, 2016

@MarcinOrlowski of course, here it is:

android-iconify-sample-debug.apk.zip

@MarcinOrlowski
Copy link
Copy Markdown

Thanks. Aside from odd "X" clear button location it seems to work.

search

@MarcinOrlowski
Copy link
Copy Markdown

There's small bug though - activity is not resized when IME opens, therefore some icons remain invisible. Yet is shall be sufficient to add

android:windowSoftInputMode="adjustResize"

to fix that.

@baurine
Copy link
Copy Markdown
Author

baurine commented May 20, 2016

@MarcinOrlowski what's your phone model and android version? in my phone has no this problem.

@MarcinOrlowski
Copy link
Copy Markdown

It's on emulator, running Android 6.0

@baurine
Copy link
Copy Markdown
Author

baurine commented May 22, 2016

@MarcinOrlowski I tried in Android 6.0 emulator, it is true like what you said, but I don't know whether it works normal in Android 6.0 physical device. maybe we can fix it after this pr is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants