Support for URLs longer than 4096 characters

[vfilanovsky]

No description provided.

[JoeDog]

I'll look at this and I'm not opposed to applying it but what browsers
support URLs longer than 4096 characters? On IE the max url is 2083
characters.

Jeff

On Tue, Mar 8, 2016 at 8:06 PM, vfilanovsky [email protected]
wrote:

---

You can view, comment on, or merge this pull request online at:

#50
Commit Summary

• Support for URLs longer than 4096 characters

File Changes

• M src/http.c https://github.com/JoeDog/siege/pull/50/files#diff-0
  (4)

Patch Links:

• https://github.com/JoeDog/siege/pull/50.patch
• https://github.com/JoeDog/siege/pull/50.diff

—
Reply to this email directly or view it on GitHub
#50.

[vfilanovsky]

Hi Jeff,

I used Siege to generate load on a mid-tier service, which is not supposed to be accessed through a browser. I guess I'm not the only one who uses Siege in this scenario. I understand both browsers and web servers might implement restrictions on URL length, but still it's a valid use case. Chrome supports URLs longer than 4k characters.

The problem here is that regardless of browser's behavior, it's possible to configure Siege with long URLs - either through URL file or command line. And if URL length exceeds 4k, Siege crashes. I think support for long URLs comes in handy, but if you have reservations, then perhaps checking the length and erroring out might be another option. Or better yet, implement both - increase supported URL length and error out when the length is exceeded.

[JoeDog]

Gotcha. I should probably move this to the heap and make it dynamic but for
now I implement your suggestion.

On Wed, Mar 9, 2016 at 2:16 AM, vfilanovsky [email protected]
wrote:

Hi Jeff,

I used Siege to generate load on a mid-tier service, which is not supposed
to be accessed through a browser. I guess I'm not the only one who uses
Siege in this scenario. I understand both browsers and web servers might
implement restrictions on URL length, but still it's a valid use case.
Chrome supports URLs longer than 4k characters.

The problem here is that regardless of browser's behavior, it's possible
to configure Siege with long URLs - either through URL file or command
line. And if URL length exceeds 4k, Siege crashes. I think support for long
URLs comes in handy, but if you have reservations, then perhaps checking
the length and erroring out might be another option. Or better yet,
implement both - increase supported URL length and error out when the
length is exceeded.

—
Reply to this email directly or view it on GitHub
#50 (comment).

[afeld]

Closes #59.