Skip to content

Conversation

@roshii
Copy link
Contributor

@roshii roshii commented Oct 17, 2025

Migrate from abandoned bencoder.pyx to fastbencode.
Update minimum Python version requirement to 3.9 (with 3.8 effectively eol since a year)

Python 3.13 compatibility will require other dependencies bumping such as twisted in #1732

Closes: #1805

@roshii roshii force-pushed the fix/bencode branch 3 times, most recently from f1dd683 to d42b411 Compare October 20, 2025 05:54
@roshii roshii marked this pull request as ready for review October 20, 2025 06:14
@roshii
Copy link
Contributor Author

roshii commented Oct 23, 2025

reverted style only changes and set fastbencode to install/use rust variant

Copy link
Contributor

@MarnixCroes MarnixCroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK
(I don't know these libraries myself, so I can't judge on that)

@kristapsk
Copy link
Member

ACK. But please squash commits.

style: revert formatting

fix(deps): update fastbencode to use rust variant

style: new line

chore: fix typo

Co-authored-by: Marnix Croes <93143998+MarnixCroes@users.noreply.github.com>

chore(deps): bump fastbencode to v0.3.6

chore(deps): remove fastbencode rust extra
@kristapsk kristapsk merged commit 94660e7 into JoinMarket-Org:master Oct 26, 2025
8 checks passed
@roshii roshii deleted the fix/bencode branch November 20, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate from bencoder.pyx

4 participants