Skip to content
This repository was archived by the owner on Apr 27, 2026. It is now read-only.

install.sh: use debian dist libffi - #1818

Merged
kristapsk merged 1 commit into
JoinMarket-Org:masterfrom
3nprob:dist-libffi
Oct 31, 2025
Merged

install.sh: use debian dist libffi#1818
kristapsk merged 1 commit into
JoinMarket-Org:masterfrom
3nprob:dist-libffi

Conversation

@3nprob

@3nprob 3nprob commented Oct 30, 2025

Copy link
Copy Markdown

We can use libffi-dev and libffi8 debian packages instead of downloading and building from source. Significantly reduces build time.

fall back to installing libffi from source like before on non-debian targets

only build libffi from source on non-debian targets
@3nprob
3nprob marked this pull request as ready for review October 30, 2025 03:26
@3nprob

3nprob commented Oct 30, 2025

Copy link
Copy Markdown
Author

As for the others:

@AdamISZ

AdamISZ commented Oct 30, 2025

Copy link
Copy Markdown
Member

tACK 8675a29

(tested on debian 6.1, full install plus running wallet-tool to check that nothing is broken).

to be clear, on libsodium our original thinking was that building from source represented less trust in external sources; but of course it's extremely debatable.

I don't have a strong opinion on it.

@kristapsk kristapsk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8675a29

@kristapsk
kristapsk merged commit 021e2e5 into JoinMarket-Org:master Oct 31, 2025
12 checks passed
@3nprob

3nprob commented Nov 1, 2025

Copy link
Copy Markdown
Author

tACK 8675a29

(tested on debian 6.1, full install plus running wallet-tool to check that nothing is broken).

Thank you for verifying!

to be clear, on libsodium our original thinking was that building from source represented less trust in external sources; but of course it's extremely debatable.

Makes sense and I agree it's not obvious.

My 5c if it were my call, I'd hold off giving the same treatment for the other two until at least:

  • libsodium: debian libsodium has any release (downgrading seems an unnecessary step back even if the dist version 1.0.18 probably works just as fine for most as it's what's in the last JM release)
  • libsecp256k1: debian bookworm unsupported by joinmarket (the dist itself is set to be EoL 2026-06 which feels reasonable to match)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants