test: fix reactor state reset after twisted.trial tests #1824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roshii
force-pushed
the
test/reactor-cleanup
branch
2 times, most recently
from
b939874 to
2e807b2
Compare
roshii
force-pushed
the
test/reactor-cleanup
branch
from
2e807b2 to
3ec6bf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a global
pytestfixture to reset the reactor's_startedBeforeflag aftertwisted.trialtests, allowing subsequent tests to use the reactor.Also cancels pending
DelayedCallsintest_irc_messaging.pyto preventDirtyReactorAggregateError.