Fix ARM/Thumb SYS gadget discovery#220
Merged
SweetVishnya merged 1 commit intoJonathanSalwan:masterfrom Dec 16, 2025
Merged
Conversation
SweetVishnya
approved these changes
Dec 16, 2025
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The arm32/thumb regexes for svc instructions were invalid, this fixes them and includes conditional suffixes for arm32 (e.g.
svceqand friends). Added big endian versions too while I was there.For the tests, this finds:
elf-ARMv7-lself-ARMv7-ls --thumbpe-Windows-ARMv7-Thumb2LE-HelloWorldJust a note, there's so many for arm32 since only ~1 nibble of the 4-byte instruction matters, so you get all of e.g.
svc #0x112233andsvc #anythingand so on. The immediate does not matter on default Linux kernels, so these are duplicates, sort of. But at least it's usable.