Feat/add onchanged to theme storage #957
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 21, 2025 16:46
allow to use the native tailwind dark mode (dark:*) for a better DX
allow to add an on changed listener for the stores
|
Your PR's base branch was set to |
|
@niko-38500 Are you'll go forward with your PRs? |
|
Yes but I'm in holiday right now, I'll resume it when I'm back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Priority*
Purpose of the PR*
Allow to subscribe to the "onChanged" storage from the custom store
Changes*
add to the base store an onChanged method and change the chrome native onchanged to be consistent with the existing call to the storage
Reference
Wait for the pr #952 to merge it