Skip to content

feat(docker): add docker support #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

niko-38500
Copy link

Priority*

  • High: This PR needs to be merged first, before other tasks.
  • Medium: This PR should be merged quickly to prevent conflicts due to common changes. (default)
  • Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*

add the support for building the extension with docker

update the README.md

Changes*

add a docker compose file a Dockerfile and an entry

How to check the feature

Read the readme.md changes to know how to test the PR

add the support for building the extension with docker

update the README.md
@PatrykKuniczak
Copy link
Collaborator

@niko-38500 I have been thinking about that :)
I'll check it ASAP

@PatrykKuniczak
Copy link
Collaborator

@niko-38500 I'm not sure, if this is really necessary.

I mean it's great idea, which i had a while ago, but for full-stack(e.g Nest + This teamplate) template.

But it seems to be overkill for simple template like us.
It seems to be overengeneering.

I'm confused.

I have plan to create full-stack template, and there i want to place docker, but i'm not sure if it's really necessary here.

Let's wait for @Jonghakseo vote.

@PatrykKuniczak
Copy link
Collaborator

And there's big issue because of lack of the /dist in root

Also lack of rimraf, which need to be installed globally inside container:
image

IMO It's not good idea to complicate template more, it's complicated a lot now.

I think it's good idea to implement it in the future in other template, which i want to implement in the future, today i was writing about it in our Discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants