Skip to content

Added <scope>dependency</scope> to dependency#10

Open
dhruviyengar wants to merge 1 commit intoJordanOsterberg:masterfrom
dhruviyengar:patch-1
Open

Added <scope>dependency</scope> to dependency#10
dhruviyengar wants to merge 1 commit intoJordanOsterberg:masterfrom
dhruviyengar:patch-1

Conversation

@dhruviyengar
Copy link
Copy Markdown

The discord server is filled with people with noclassdeffound, simply saved by adding the dependency scope to the dependency.

The discord server is filled with people with noclassdeffound, simply saved by adding the dependency scope to the dependency.
@Erik-For
Copy link
Copy Markdown

I think this is a good change

@JordanOsterberg
Copy link
Copy Markdown
Owner

Can you verify that this change does resolve the exception if instructions are followed? Will merge pending that verification.

@sqlongithub
Copy link
Copy Markdown

sqlongithub commented Dec 1, 2021

As far as I know there are only 6 scopes:

  • compile
  • provided
  • runtime
  • test
  • system
  • import

(https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#dependency-scope)

@dhruviyengar
Copy link
Copy Markdown
Author

As far as I know there are only 6 scopes:

  • compile
  • provided
  • runtime
  • test
  • system
  • import

(https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#dependency-scope)

it actually does exist, it's to let the shade plugin know that this is a jar that needs to be shaded in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants