Skip to content

Feature/ignore deps#18

Merged
Joschi3 merged 4 commits into
mainfrom
feature/ignore_deps
Apr 22, 2026
Merged

Feature/ignore deps#18
Joschi3 merged 4 commits into
mainfrom
feature/ignore_deps

Conversation

@Joschi3
Copy link
Copy Markdown
Owner

@Joschi3 Joschi3 commented Apr 22, 2026

Summary

Three related dependency-handling improvements that give users finer control over what package.xml must declare:

  • ignore-deps / globally (CLI) or per-package (XML comment) suppress specific dependencies so they are not flagged as missing and not auto-filled. Intended for cases like rviz2 pulling in heavy transitive GUI deps that should not be installed on every target machine.
  • skip-launch-dep-check: skip scanning launch/, components/, and test/ folders for implicit exec_depend / test_depend entries. Useful for packages where launch-file scanning produces false positives or is otherwise undesirable.
  • find_package(pkg QUIET) is no longer enforced: a bare QUIET lookup (without REQUIRED) is semantically optional in CMake (the build continues if the package is missing), so the validator now treats it as optional and does not require it to appear in package.xml. find_package( REQUIRED QUIET) remains enforced

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
package_xml_validation/helpers/exception_parser.py 95.45% 1 Missing ⚠️
package_xml_validation/package_xml_validator.py 90.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@Joschi3 Joschi3 merged commit c3dfde6 into main Apr 22, 2026
2 checks passed
@Joschi3 Joschi3 deleted the feature/ignore_deps branch April 22, 2026 17:04
Joschi3 added a commit that referenced this pull request May 5, 2026
Bring per-package dependency exception support (#18) into the typing
branch. Conflicts touched the two files where the typing pass overlapped
with the new 'exceptions' parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants