Add regression-guard tests for validation steps, CMake parser, and ro…#23
Merged
Joschi3 merged 2 commits intoMay 13, 2026
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Why
PRs #21 and #22 added significant new code without matching unit tests.
Several logical branches had no test pinning their behaviour — they worked,
but nothing would catch a future refactor that quietly inverts a condition,
drops a warning, or reorders a sort. This PR closes those gaps. The goal is
regression protection, not coverage-number theatre.
What's tested now that wasn't before
Validation step branches
CMakeComparisonStep: missingCMakeLists.txt, strict-vs-non-strictunresolved-dep reporting,
evaluate_conditions=Falseformatter fallback.RosdepCheckStep: all three early-return paths.BuildTypeExportStep: check-only missing/wrong type, no-auto-fillcritical error, auto-fill success path.
PackageXmlValidator:compare_with_cmake && !check_rosdepsguard,malformed-XML continuation.
Parsing & resolution logic
cmake_parsers:find_package(... QUIET)withoutREQUIREDis skipped;resolve_for_eachcorrectly expandsforeach(... IN LISTS ...)blocks.rosdep_validator.search_rosdep_candidates: the 4-tier sort order,length tiebreaks, and the 5-result cap.
Filesystem / workspace edge cases
launch/directory are skipped during launch-depdiscovery.
workspace.get_pkgs_in_wrspkg_dir is Nonefallback.verify_rosdep_mapping: YAML load failure and per-keyResolutionErrorpaths.
resolve_indentationempty-root /tail=None/ no-newline fallbacks.162 → 194 tests, all passing. No production code changes.