zenspider frozen strings #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshCheek
merged commit 833afdc
into
JoshCheek:updating-for-ruby-3
0 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a commit that cleans up and fixes all frozen-string errors. I get these because I have
export RUBYOPT=--enable-frozen-string-literal... this can be further helped (but slower to run) adding--debug=frozen-string-literalto that var.In MOST cases, I tried to push fixes into lib but some specs were modifying strings they were creating so fixes wound up there.
I think there is one case where I think the fix should be pushed up to lib but the spec as written was expecting modification of a local string. I left it as the "obvious" fix to the
expectline didn't work for some reason.