Fix/build script exit issue #1248
Open
+125
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidated common logic for loading suite, flavor, and board into a single load_config function. Reduced repetitive cd commands and improved error handling. Streamlined partial-build checks (kernel-only, rootfs-only, etc.) for early exits. Ensured original functionality remains intact while enhancing code clarity.
On some systems like Ubuntu 24.04, the build.sh script could exit prematurely if output redirection to `tee` was used and the script needed to terminate early due to missing parameters for a full build. This occurred because `set -e` would cause the script to exit if `tee` terminated with a non-zero status, which can happen if it receives a SIGPIPE when the script calls `exit`. This could preempt the intended error messaging (e.g., the usage instructions). The fix involves making the `tee` command within the process substitution more resilient by appending `|| true`: `exec > >(tee "build/logs/build-$(date +"%Y%m%d%H%M%S").log" || true) 2>&1` This ensures that if `tee` exits due to a SIGPIPE (or another error) when the script is intentionally exiting, its exit status does not itself trigger an immediate script termination via `set -e`, allowing the script's own exit procedures (like printing usage) to complete.
|
This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 14 days. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.