Cleanup Location Info#5
Draft
EnKdev wants to merge 13 commits into
Draft
Conversation
# Conflicts: # Archipelago.RetroArchClient/OcarinaOfTime/Data/AllLocationInformation.cs
…it them up into their own respective YAML files. Also removed a few unnecessary comments at this point.
…es doesn't hurt, right?
…r location data up a little.
This changes the feedback from this: "Reading .\Data\location_info_BotW.yaml..." to this: "Reading ./Data/location_info_BotW.yaml..."
Comment on lines
+414
to
+419
| // This is super convoluted, but god forbid me to be able to use our LocationInformation object directly. | ||
| // However, I tested this, and it reads every file without issue and creates respective location information | ||
| // objects without skipping a single location. | ||
| foreach (var file in Directory.GetFiles("./Data")) | ||
| { | ||
| // Screw windows with using backslashes for paths. |
Owner
There was a problem hiding this comment.
I'd prefer to not have comments like this left in the code, if there's gonna be comments they should be simple and have a real purpose.
Owner
There was a problem hiding this comment.
I meant the Screw windows comment too, I don't like windows at all, I just don't think that kind of comment belongs in code.
# Conflicts: # Archipelago.RetroArchClient/Archipelago.RetroArchClient.csproj # Archipelago.RetroArchClient/OcarinaOfTime/OoTClient.cs # Archipelago.RetroArchClient/OcarinaOfTime/Services/LocationCheckService.cs
WIP, will take some time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits the hardcoded data from within the AllLocationInformation.cs file into their own respective location files up, thus removing hardcoded data and reducing the code size by a bit.