Skip to content

Add eigen dependency #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Add eigen dependency #47

wants to merge 34 commits into from

Conversation

JoshuaSBrown
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

Merging #47 (1d8fcc5) into master (35b23b4) will increase coverage by 0.28%.
The diff coverage is 99.78%.

❗ Current head 1d8fcc5 differs from pull request most recent head 336f378. Consider uploading reports for the commit 336f378 to get more accurate results

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
+ Coverage   96.12%   96.41%   +0.28%     
==========================================
  Files          44       44              
  Lines        1602     1758     +156     
==========================================
+ Hits         1540     1695     +155     
- Misses         62       63       +1     
Impacted Files Coverage Δ
src/libcatnip/io/file_readers/filereader.hpp 100.00% <ø> (ø)
src/libcatnip/io/file_readers/punreader.hpp 100.00% <ø> (ø)
src/libcatnip/qc_functions.hpp 100.00% <ø> (ø)
src/tools/main.cpp 88.04% <95.23%> (-1.54%) ⬇️
src/libcatnip/io/file_readers/logreader.hpp 100.00% <100.00%> (ø)
src/libcatnip/parameters.hpp 100.00% <100.00%> (ø)
src/tests/test_logreader.cpp 100.00% <100.00%> (ø)
src/tests/test_punreader.cpp 100.00% <100.00%> (ø)
src/tests/test_qc_functions.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b99860d...336f378. Read the comment docs.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 55 Code Smells

0.0% 0.0% Coverage
6.5% 6.5% Duplication

@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2022

This pull request fixes 9 alerts when merging 336f378 into b99860d - view on LGTM.com

fixed alerts:

  • 8 for Resource not released in destructor
  • 1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant