-
-
Notifications
You must be signed in to change notification settings - Fork 26
Add Ruff linter support for stub quality checking with flake8-pyi rules #838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Josverl <[email protected]>
Co-authored-by: Josverl <[email protected]>
Co-authored-by: Josverl <[email protected]>
Co-authored-by: Josverl <[email protected]>
Co-authored-by: Josverl <[email protected]>
|
@copilot ModuleNotFoundError: No module named 'requests' https://github.com/Josverl/micropython-stubs/actions/runs/18578590215/job/52969579062 Can you also fix that |
Co-authored-by: Josverl <[email protected]>
Fixed in commit d52ac09 - added |
Adding Ruff Linter Support to Stubs Quality Checks ✅
Issue: Check stubs with additional linters - specifically ruff
Status: COMPLETE
Implementation Summary
Successfully integrated Ruff as a third linter for MicroPython stubs quality checking, alongside Pyright and MyPy.
Completed Tasks
Key Features
✨ Fast linting: 10-100x faster than traditional linters
✨ Stub-aware: Built-in flake8-pyi rules for .pyi files
✨ Configured: Proper ignores for MicroPython stub characteristics
✨ Integrated: Works seamlessly with existing pyright/mypy infrastructure
✨ Documented: Complete usage guide and configuration examples
Files Changed
Testing Results
✅ Ruff module imports successfully
✅ Runs on test directories without errors
✅ Validates stub files correctly (micropython-preview-docstubs passes)
✅ Configuration properly ignores MicroPython-specific patterns
✅ CI error fixed - requests module now in requirements-test.txt
Original prompt
Fixes #746
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.