Version Packages - #234
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@pracht/adapter-cloudflare@0.5.2
Patch Changes
7cdfa59]:@pracht/adapter-node@0.3.2
Patch Changes
7cdfa59]:@pracht/adapter-vercel@0.2.2
Patch Changes
7cdfa59]:@pracht/cli@1.7.2
Patch Changes
7cdfa59]:@pracht/core@0.10.2
Patch Changes
#233
7cdfa59Thanks @JoviDeCroock! - Fix a repeat click on an in-page fragment link doing nothing.Fragment links were left to the browser, which works once: the browser pushes an
entry with no scroll key, and the router recognizes the
popstatethat followsas a fragment navigation rather than a traversal — but stamps a scroll key onto
that entry in the process. Clicking the same link again reuses the entry, so the
key is now there, the
popstatereads as a back/forward traversal, and theposition saved for the entry (the top of the page, where the user had scrolled
back to) is faithfully restored. The click was dead.
The client router now commits fragment link clicks itself — pushing the history
entry, scrolling to the target, and moving focus there — so a repeat click always
scrolls, and
popstateis left to mean "traversal", which is what thescroll-key logic assumes.
hashchangeis dispatched for the interceptednavigation, since
pushStatefires none. Thepopstateguard stays as thefallback for fragment entries created another way (
location.hash = "…").@pracht/vite-plugin@0.6.2
Patch Changes
7cdfa59]:@pracht/example-basic@0.0.22
Patch Changes
7cdfa59]:@pracht/example-cloudflare@0.0.23
Patch Changes
7cdfa59]:@pracht/example-docs@0.0.23
Patch Changes
7cdfa59]:@pracht/example-islands@0.0.4
Patch Changes
7cdfa59]:@pracht/example-pages-router@0.0.22
Patch Changes
7cdfa59]:@pracht/example-showcase@0.0.15
Patch Changes
7cdfa59]:@pracht/example-tsrx@0.0.9
Patch Changes
7cdfa59]: