fix(capabilities): separate capability declarations from definitions#40
Merged
Jpisnice merged 1 commit intoDec 17, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(capabilities): separate capability declarations from definitions
Summary
capabilitiesdeclaration from the detailed definitions to satisfy the MCP SDK types and fix a TypeScript compile error.What I changed
capabilitiesobject with:capabilities(declaration-only:{ resources: {}, prompts: {}, tools: {} })resourceDefinitions(detailed resource metadata)promptDefinitions(detailed prompt metadata)toolDefinitions(detailed tool metadata)Why
capabilitiesto only declare supported categories (e.g., that prompts are supported); providing full prompt definitions incapabilitiescaused a type mismatch and a TS compilation error. Separating declarations from definitions keeps detailed metadata available for handlers while satisfying the SDK types.Verification
pnpm build— TypeScript compiles with no errors.How to test
Notes for reviewers
promptDefinitions) and register them with the server as-needed.fix/capabilities-separate-definitions→ targetmaster