Refactor to Use Functions and Conditional Execution#40
Open
newnix wants to merge 3 commits into
Open
Conversation
* UbuntuServer_18.04LTS/helpers.sh - Change shebang to `#!/usr/bin/env bash` - Collect numeric user id as CUID - Add function `perr()` - Replace echo statements with printf where possible - `__get_ip()` now only sets the address - Rename `tunning` -> `tuning` - Remove needless variable `whoapp` * UbuntuServer_18.04LTS/jshielder.sh - Change shebang to `#!/usr/bin/env bash` - Remove extraneous `echo` statements in `f_banner` - Add call to `clear` in `f_banner` - Update `check_root()` to use `CUID` from helper scripts * jsheilder.sh - Create `main` function - Simplify and generalize distro/system selection - Utilize `perr` and printf instead of echo where possible
* UbuntuServer_18.04LTS/helpers.sh
- Add echo to `spinner`
* UbuntuServer_18.04LTS/
- Evaluate `MYNAME`
- Turn unconditional command chains into lists with conditional
execution, typically using `{}` and `&&` constructs
- Add `-r` to all `read` calls
- Utilize `printf` to reduce calls to `echo` and some loops
- Add comments noting where improvements can be made, that would
require some deeper understanding of the script functionality to
ensure proper configuration
- Remove calls to `clear` before `f_banner`
- Simplify handling of `/tmp` modifications
- Utilize subshells when traversing the filesystem using `cd`
- Reduce several installation steps to single lines
- Ensure proper quoting of variables
- Simplify subshell in `additional_hardening` to not pipe `awk(1)`
into `grep(1)`
- Turn `disable_compilers` into a loop
- Moved menu selection logic into newly created `main()` function
* UbuntuServer_18.04LTS/templates/bashrc-user
- Use `openssl(1)` instead of php to calculate MD5 digest
Owner
|
Wow, lots of changes.. Will test out and merge..... Thanks for the contribution. |
|
Core logic under bash function |
|
Tak for hurtigt svar.
Håber i løser det hurtigt da jeg har et par kunder der er meget sure
Mvh
Fra: Egbert ***@***.***>
Sendt: 29. marts 2022 14:30
Til: Jsitech/JShielder ***@***.***>
Cc: Subscribed ***@***.***>
Emne: Re: [Jsitech/JShielder] Refactor to Use Functions and Conditional Execution (#40)
Core logic under bash function main() is also detailed in Google Shell Style Guide document.
https://google.github.io/styleguide/shellguide.html
—
Reply to this email directly, view it on GitHub <#40 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIRAY7QKUEDL6XWO6GA3AADVCLZSZANCNFSM4PFL4GNQ> .
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned here, bring in several improvements to the flow of execution, making sure that directory changes are done in subshells, certain subshells are more streamlined, several calls to
echoare replaced withprintf, core logic is encapsulated inside newmain()functions and notes on continued improvements are made in comments where the changes would require more time or deeper understanding regarding how the script functions.