Skip to content

Conversation

@Y0dler
Copy link
Contributor

@Y0dler Y0dler commented Mar 20, 2025

More recent nutpie versions take initial values via the init_means argument (as opposed to initvals with the default sampler). Accordingly, nutpie can now be employed for faster sampling.

@github-actions
Copy link

github-actions bot commented Mar 20, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Y0dler
Copy link
Contributor Author

Y0dler commented Mar 20, 2025

  • The JuBiotech maintainers know my real name.

At least one of the following two applies:

  • The JuBiotech maintainers know my current employer.

  • I am not making this contribution on behalf of my current employer.

@Y0dler
Copy link
Contributor Author

Y0dler commented Mar 20, 2025

I have read the CLA Document and I hereby sign the CLA.

@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.30%. Comparing base (0d9c552) to head (7cbb944).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
bletl/growth.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   93.43%   93.30%   -0.14%     
==========================================
  Files          11       11              
  Lines        1219     1239      +20     
==========================================
+ Hits         1139     1156      +17     
- Misses         80       83       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Y0dler Y0dler requested a review from michaelosthege March 24, 2025 16:50
@Y0dler
Copy link
Contributor Author

Y0dler commented Mar 24, 2025

I don't think that sampling is covered in test_growth.py, hence the lowered coverage.

Copy link
Member

@michaelosthege michaelosthege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity: How much faster is the nutpie sampler in comparison?

@michaelosthege michaelosthege merged commit ad8f221 into main Mar 25, 2025
10 of 12 checks passed
@michaelosthege michaelosthege deleted the add-nutpie-support branch March 25, 2025 11:56
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants