Skip to content

Conversation

@alecloudenback
Copy link
Member

@alecloudenback alecloudenback commented Jan 7, 2023

Try using a juila-native package for performance.

Unfortunately, it seems like reading the tables is dominated by the slower performance of XML.Document versus XMLDict.xml_dict

Using XMLDict:

julia> @btime MortalityTables.get_SOA_table(1117)
  6.108 μs (62 allocations: 6.70 KiB)

Using XML.jl (using the jd/rewrite branch):

julia> @btime MortalityTables.get_SOA_table2(1117)
  4.304 ms (164793 allocations: 10.78 MiB)
  • needs to parse metadata in parseXTbMLTable2

@alecloudenback alecloudenback marked this pull request as draft January 7, 2023 06:30
@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Merging #125 (17078c7) into master (aa662ae) will decrease coverage by 10.42%.
The diff coverage is 9.37%.

❗ Current head 17078c7 differs from pull request most recent head 0af15c4. Consider uploading reports for the commit 0af15c4 to get more accurate results

@@             Coverage Diff             @@
##           master     #125       +/-   ##
===========================================
- Coverage   90.63%   80.22%   -10.42%     
===========================================
  Files           9        9               
  Lines         395      450       +55     
===========================================
+ Hits          358      361        +3     
- Misses         37       89       +52     
Impacted Files Coverage Δ
src/MortalityTables.jl 100.00% <ø> (ø)
src/get_SOA_table.jl 52.94% <0.00%> (-47.06%) ⬇️
src/XTbML.jl 43.07% <5.66%> (-22.04%) ⬇️
src/MortalityTable.jl 96.72% <100.00%> (+0.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants