Open
Conversation
Member
|
Thanks, could you add a test ? |
Author
|
I'm not sure what test to add for this - the Julia docs state that |
Member
|
Adding promote_type(Any, typeof(MP.changecoefficienttype(x + 1, Any)))in https://github.com/JuliaAlgebra/MultivariatePolynomials.jl/blob/master/test/promote.jl should cover it. |
added 2 commits
April 9, 2022 11:00
Author
|
I managed to avoid the issue with some restructuring, but in the interest of closing this I added the proposed test |
|
I ran into a similar stack overflow error doing this: using DynamicPolynomials
@polyvar x
@ncpolyvar y
x + yMight be the same underlying problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to this issue. The generic
promote_rulein question is provided symmetrically (as far as I'm awarepromote_typetakes care of that), but the specialisation toT=Anyis only provided in one direction. This fixes the problem I was having.