Skip to content

Fix isapprox for terms #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blegat wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix isapprox for terms #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89ab4dd
Fix isapprox for terms
blegat Feb 9, 2026
cb656f4
Fix format
blegat Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/operators.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@ for op in [:+, :-]
return $op(map_coefficients(J -> J.λ, p1, nonzero = true), p2)
end
end

function Base.isapprox(t1::AbstractTermLike, t2::AbstractTermLike; kwargs...)
return isapprox(coefficient(t1), coefficient(t2); kwargs...) &&
monomial(t1) == monomial(t2)
end

function Base.isapprox(p1::_APL, p2::_APL; kwargs...)
return isapprox(promote(p1, p2)...; kwargs...)
end
Expand Down
11 changes: 11 additions & 0 deletions test/commutative/comparison.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,27 @@
@testset "Monomial equality" begin
Mod.@polyvar x y
@test 1 == constant_monomial(x)
@test 1 ≈ constant_monomial(x)
@test 2 != constant_monomial(x)
@test !(2 ≈ constant_monomial(x))
@test 2 != x
@test !(2 ≈ x)
@test 2 != x * y
@test !(2 ≈ x * y)
@test x * y != x
@test !(x * y ≈ x)
@test 1x * y == x * y
@test 1x * y ≈ x * y
@test 2x * y != x * y
@test !(2x * y ≈ x * y)
@test x == monomial(x)
@test x ≈ monomial(x)
@test x * y^0 == x
@test x * y^0 ≈ x
@test x != x^0 * y
@test !(x ≈ x^0 * y)
@test x^2 != x * y
@test !(x^2 ≈ x * y)
end
@testset "Polynomial equality" begin
Mod.@polyvar x y
Expand Down
Loading