SOneTo subtypes AbstractOneTo#1302
Merged
jishnub merged 4 commits intoJuliaArrays:masterfrom Dec 19, 2025
Merged
Conversation
nsajko
reviewed
Sep 12, 2025
Co-authored-by: Neven Sajko <4944410+nsajko@users.noreply.github.com>
mateuszbaran
reviewed
Dec 8, 2025
mateuszbaran
reviewed
Dec 8, 2025
Collaborator
|
LGTM up to these two minor comments. |
Co-authored-by: Mateusz Baran <mateuszbaran89@gmail.com>
mateuszbaran
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a recent nightly (v"1.13.0-DEV.347"),
Basehas addedAbstractOneTo(JuliaLang/julia#56902), and in this PR we changeSOneToto subtypeAbstractOneTowhen this is available. This makes combinations ofSOneTo,Base.OneToandIntegers dispatch toBasemethods, and we don't need to disambiguate these in this package.Fixes #1248. After this,
StaticArraysonly needs to definesimilarmethods forTuples ofSOneToas indices.