Skip to content

add support for reinterpert(reshape, ...)#26

Merged
oschulz merged 2 commits intoJuliaArrays:mainfrom
Joroks:reinterpret_reshape
May 4, 2025
Merged

add support for reinterpert(reshape, ...)#26
oschulz merged 2 commits intoJuliaArrays:mainfrom
Joroks:reinterpret_reshape

Conversation

@Joroks
Copy link
Copy Markdown
Contributor

@Joroks Joroks commented May 3, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented May 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.98%. Comparing base (e4f2b66) to head (b7d1a96).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   97.82%   97.98%   +0.16%     
==========================================
  Files           3        3              
  Lines         138      149      +11     
==========================================
+ Hits          135      146      +11     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oschulz
Copy link
Copy Markdown
Collaborator

oschulz commented May 4, 2025

@Joroks Can you fix the test failure on v1.0? Alternatively we can also require v1.10 now.

@Joroks
Copy link
Copy Markdown
Contributor Author

Joroks commented May 4, 2025

@oschulz reinterpret(reshape, ...) requires at least Julia version 1.6. The test failiure is only because we compare our reinterpret(reshape, ...) with the build-in implementation, which doesn't exist in v1.0. The most recent commit should fix this issue.

@oschulz oschulz merged commit 7664ee5 into JuliaArrays:main May 4, 2025
8 checks passed
@oschulz
Copy link
Copy Markdown
Collaborator

oschulz commented May 4, 2025

Thanks @Joroks !

JuliaRegistries/General#130291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants