Skip to content

Base.sizeof(::UnsafeArray)#31

Closed
green-nsk wants to merge 1 commit intoJuliaArrays:mainfrom
green-nsk:sf/sizeof
Closed

Base.sizeof(::UnsafeArray)#31
green-nsk wants to merge 1 commit intoJuliaArrays:mainfrom
green-nsk:sf/sizeof

Conversation

@green-nsk
Copy link
Copy Markdown
Contributor

sizeof(::DenseArray) is relied upon in places, but returns the wrong thing for UnsafeArray

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.14%. Comparing base (2a2a745) to head (cafbe96).

Files with missing lines Patch % Lines
src/unsafe_array.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   97.84%   97.14%   -0.70%     
==========================================
  Files           3        3              
  Lines         139      140       +1     
==========================================
  Hits          136      136              
- Misses          3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oschulz
Copy link
Copy Markdown
Collaborator

oschulz commented Mar 29, 2026

Replaced by #32 .

@oschulz oschulz closed this Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants